cmd/compile/internal/ssa: add codegen for Zicond extension on riscv64 #75577

lxq015 · 2025-09-24T04:38:54Z

This patch convert branches to CondSelect and optimize to Zicond instructions.

Follow-up to CL 631595
Updates #75350

gopherbot · 2025-09-24T04:48:07Z

This PR (HEAD: f5f9d07) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/705996.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2025-09-24T04:55:52Z

Message from Gopher Robot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/705996.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-09-24T09:34:03Z

Message from Mark Ryan:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/705996.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-09-25T08:45:22Z

This PR (HEAD: 58e1e0c) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/705996.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2025-09-25T09:09:46Z

Message from Xueqi Luo:

Patch Set 2:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/705996.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-13T08:43:58Z

Message from Xueqi Luo:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/705996.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-13T14:33:02Z

Message from Joel Sing:

Patch Set 2: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/705996.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-13T14:41:03Z

Message from Gopher Robot:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/705996.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-16T09:50:37Z

Message from Gopher Robot:

Patch Set 2:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/705996.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-17T20:52:57Z

Message from Dmitri Shuralyov:

Patch Set 2: Commit-Queue+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/705996.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-17T20:52:57Z

Message from Go LUCI:

Patch Set 2:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2025-10-17T20:47:34Z","revision":"a7132c18e5acb55b578bd3cbdeb82ffcd9700498"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/705996.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-17T21:18:30Z

Message from Dmitri Shuralyov:

Patch Set 2: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/705996.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-17T21:18:30Z

Message from Go LUCI:

Patch Set 2:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/705996.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-17T21:18:31Z

Message from Go LUCI:

Patch Set 2: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/705996.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-19T21:33:31Z

Message from Michael Munday:

Patch Set 2:

(5 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/705996.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-21T08:27:32Z

This PR (HEAD: 00604c6) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/705996.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2025-10-21T22:07:22Z

Message from Michael Munday:

Patch Set 4:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/705996.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-22T09:19:14Z

This PR (HEAD: 9e3f91a) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/705996.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2025-10-22T09:30:23Z

Message from Xueqi Luo:

Patch Set 4:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/705996.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-22T15:34:25Z

Message from Joel Sing:

Patch Set 5: Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/705996.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-22T15:34:26Z

Message from Go LUCI:

Patch Set 5:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2025-10-22T15:27:55Z","revision":"a78d7cefbf4d1e3b2df625c9389c8fa01f7aef09"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/705996.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-22T16:02:45Z

Message from Joel Sing:

Patch Set 5: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/705996.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-22T16:02:46Z

Message from Go LUCI:

Patch Set 5:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/705996.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-22T16:02:47Z

Message from Go LUCI:

Patch Set 5: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/705996.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-23T20:59:25Z

Message from Michael Munday:

Patch Set 5:

(9 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/705996.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-11-04T07:05:56Z

This PR (HEAD: cd67025) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/705996.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2025-11-04T07:30:44Z

Message from Xueqi Luo:

Patch Set 6:

(15 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/705996.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-11-17T02:48:53Z

Message from Meng Zhuo:

Patch Set 7: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/705996.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-11-17T02:48:54Z

Message from Go LUCI:

Patch Set 7:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/705996.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-11-17T02:48:54Z

Message from Go LUCI:

Patch Set 7: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/705996.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-11-17T04:37:54Z

Message from Meng Zhuo:

Patch Set 8: Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/705996.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-11-17T04:37:55Z

Message from Go LUCI:

Patch Set 8:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2025-11-17T04:22:49Z","revision":"87894a8d2e78238044f1ae301c18f5c326d2413d"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/705996.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-11-17T04:45:20Z

Message from Meng Zhuo:

Patch Set 8: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/705996.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-11-17T04:45:21Z

Message from Go LUCI:

Patch Set 8:

This CL has failed the run. Reason:

Tryjob golang/try/gotip-linux-amd64_avx512 has failed with summary (view all results):

go on master (change 705996)

To reproduce, try gomote repro 8697983684935879697.

Additional links for debugging:

go tool dist test -json output [shard 4]

Please don’t reply on this GitHub thread. Visit golang.org/cl/705996.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-11-17T04:45:21Z

Message from Go LUCI:

Patch Set 8: LUCI-TryBot-Result-1

Please don’t reply on this GitHub thread. Visit golang.org/cl/705996.
After addressing review feedback, remember to publish your drafts!

This patch adds code generation support for the Zicond extension. We convert branches into CondSelect operations in branchelim and rewrite them into Zicond instructions. Additionally, optimization rules have been added to optimize more conditional branch scenarios based on the riscv-isa-manual. Follow-up to CL 631595 Updates golang#75350 Change-Id: If3f6dbff2fc165addfb4e511e0ac618419d59103

gopherbot · 2025-11-17T15:45:55Z

Message from Mark Ryan:

Patch Set 8:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/705996.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-11-18T09:10:56Z

Message from Xueqi Luo:

Patch Set 8:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/705996.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-11-18T11:13:07Z

This PR (HEAD: 93dfc1c) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/705996.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2025-11-18T12:24:21Z

Message from Xueqi Luo:

Patch Set 8:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/705996.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-11-18T13:58:25Z

Message from Joel Sing:

Patch Set 9:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/705996.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-11-19T01:52:46Z

Message from Xueqi Luo:

Patch Set 9:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/705996.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-11-19T02:00:22Z

This PR (HEAD: c1f9fd5) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/705996.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2025-11-19T02:15:49Z

This PR (HEAD: 888203a) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/705996.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

austinderek mentioned this pull request Sep 24, 2025

cmd/compile/internal/ssa: add codegen for Zicond extension on riscv64 PullRequestInc/go#85

Closed

lxq015 force-pushed the zicond-codegen-support branch from 2f5ba88 to 58e1e0c Compare September 25, 2025 08:44

lxq015 force-pushed the zicond-codegen-support branch from 9e3f91a to cd67025 Compare November 4, 2025 07:04

lxq015 added 10 commits November 17, 2025 14:10

add tests

4363f79

move tests in zicond.go to condmove.go

c80a19c

change rules form1

9f0e7d8

change rules form2

2173476

fix test file

d9b5ec6

fix test case

6dc2657

add some rules

e1da54e

fix merge conflict and form of rules

4d50be6

use spaces instead of commas in codegen tests

a8ed996

fix bug

93dfc1c

lxq015 force-pushed the zicond-codegen-support branch from e6b2eee to 93dfc1c Compare November 18, 2025 11:12

use MOVBUreg to zero the upper bytes

c1f9fd5

delete extra space

888203a

cmd/compile/internal/ssa: add codegen for Zicond extension on riscv64 #75577

Are you sure you want to change the base?

cmd/compile/internal/ssa: add codegen for Zicond extension on riscv64 #75577

Conversation

lxq015 commented Sep 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gopherbot commented Sep 24, 2025

Uh oh!

gopherbot commented Sep 24, 2025

Uh oh!

gopherbot commented Sep 24, 2025

Uh oh!

gopherbot commented Sep 25, 2025

Uh oh!

gopherbot commented Sep 25, 2025

Uh oh!

gopherbot commented Oct 13, 2025

Uh oh!

gopherbot commented Oct 13, 2025

Uh oh!

gopherbot commented Oct 13, 2025

Uh oh!

gopherbot commented Oct 16, 2025

Uh oh!

gopherbot commented Oct 17, 2025

Uh oh!

gopherbot commented Oct 17, 2025

Uh oh!

gopherbot commented Oct 17, 2025

Uh oh!

gopherbot commented Oct 17, 2025

Uh oh!

gopherbot commented Oct 17, 2025

Uh oh!

gopherbot commented Oct 19, 2025

Uh oh!

gopherbot commented Oct 21, 2025

Uh oh!

gopherbot commented Oct 21, 2025

Uh oh!

gopherbot commented Oct 22, 2025

Uh oh!

gopherbot commented Oct 22, 2025

Uh oh!

gopherbot commented Oct 22, 2025

Uh oh!

gopherbot commented Oct 22, 2025

Uh oh!

gopherbot commented Oct 22, 2025

Uh oh!

gopherbot commented Oct 22, 2025

Uh oh!

gopherbot commented Oct 22, 2025

Uh oh!

gopherbot commented Oct 23, 2025

Uh oh!

gopherbot commented Nov 4, 2025

Uh oh!

gopherbot commented Nov 4, 2025

Uh oh!

gopherbot commented Nov 17, 2025

Uh oh!

gopherbot commented Nov 17, 2025

Uh oh!

gopherbot commented Nov 17, 2025

Uh oh!

gopherbot commented Nov 17, 2025

Uh oh!

gopherbot commented Nov 17, 2025

Uh oh!

gopherbot commented Nov 17, 2025

Uh oh!

gopherbot commented Nov 17, 2025

Uh oh!

gopherbot commented Nov 17, 2025

Uh oh!

gopherbot commented Nov 17, 2025

Uh oh!

gopherbot commented Nov 18, 2025

lxq015 commented Sep 24, 2025 •

edited

Loading